Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2119, #2121] Support spells above level 9, allow pact progression customization #2122

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Jan 27, 2023

Removes the default spell levels defined in template and adjusts prepareLeveledSlots so it is based on the spell levels defined in config, not in the actor data. Also refactors a few other places that were hard-coded to handle nine levels of spells.

Resolves #2119

Moves pact progression configuration out of the preparePactSlots method into config for easier customization.

Resolves #2121

@arbron arbron requested a review from Fyorl January 29, 2023 01:43
@krbz999
Copy link
Contributor

krbz999 commented May 10, 2023

What happens if you attempt to make a spell scroll from a 10th level spell? DND5E.spellScrollIds only goes up to 9.

@arbron arbron modified the milestones: D&D5E 2.2.0, D&D5E 2.3.0 May 13, 2023
@arbron arbron changed the base branch from 2.2.x to 2.3.x July 16, 2023 17:42
@Fyorl Fyorl merged commit 36d7460 into foundryvtt:2.3.x Jul 20, 2023
@arbron arbron deleted the spell/level-10 branch July 20, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pact casting progression to be configured Spell levels above 9 not supported
3 participants