Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1564] Convert property attribution to use tooltips #2081

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

arbron
Copy link
Collaborator

@arbron arbron commented Jan 19, 2023

Makes the property attributions more consistent with other parts of the sheet and fixes the rendering issue that was preventing the expansion of attributions to other parts of the sheet.

Resolves #1564

@arbron arbron added the ui User interface related features or bugs label Jan 19, 2023
@arbron arbron added this to the D&D5E 2.1.3 milestone Jan 19, 2023
@arbron arbron requested a review from Fyorl January 19, 2023 19:31
@arbron arbron self-assigned this Jan 19, 2023
@arbron arbron linked an issue Jan 19, 2023 that may be closed by this pull request
Copy link
Contributor

@Fyorl Fyorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Since this is a deprecation, should we wait for 2.2? Seems like a pretty small potential blast radius though.

less/apps.less Show resolved Hide resolved
@arbron
Copy link
Collaborator Author

arbron commented Jan 20, 2023

Code looks good. Since this is a deprecation, should we wait for 2.2? Seems like a pretty small potential blast radius though.

There shouldn't be any actual change in behavior for 3rd party sheets using this, other than the deprecation warning, so I'd probably say it is good now. Up to you.

@arbron arbron requested a review from Fyorl January 20, 2023 20:26
@Fyorl Fyorl merged commit 22fad03 into foundryvtt:2.1.x Jan 20, 2023
@arbron arbron deleted the ui/tooltip-attribution branch January 25, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui User interface related features or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert PropertyAttribution to use new tooltips system
2 participants