[#881] Add spell level and item id to message flags when a spell is cast

[krbz999]

This is a one-liner to add a spell's level, as well as its item id, as flags.dnd5e.use.spellLevel: <Number>, and hopefully resolve #881.

I have put this in a separate PR to get some feedback on what the best flag would be; attack rolls use flags.dnd5e.roll.type: "attack" and damage rolls use flags.dnd5e.roll.type: "damage", and this is not entirely in line with that, but using flags.dnd5e.roll.type: "use" didn't seem correct either.

[Varriount]

Huh, is the original item ID not already attached to the chat card?

[krbz999]

On item.use() there are no system flags at all. The item id and the spell level have always been present in the dataset, however. But as the issue says, this makes it easier.

[arbron]

I'm wondering if it would just be simpler to put these at the top level, so flags.dnd5e.spellLevel and flags.dnd5e.itemId. Or perhaps something like flags.dnd5e.item.level & flags.dnd5e.item.id.

Also, it would probably be better to store the item's UUID rather than the ID otherwise it would be difficult to retrieve the original item. And the ID should be stored for all items rather than just spells.

[krbz999]

I had the same thought about putting it at the top level. Something like flags.dnd5e.use: {type: item.type, itemId: item.id} and spellLevel when it is a spell.

I chose the item id because that is what is stored on attack rolls and damage rolls. Should those be changed?

[Fyorl]

@krbz999

I chose the item id because that is what is stored on attack rolls and damage rolls. Should those be changed?

Perhaps, in order to avoid breakage, we can include both for now, and retire itemId later? Could you update attack and damage rolls to include itemUuid as well?

[krbz999]

@krbz999

I chose the item id because that is what is stored on attack rolls and damage rolls. Should those be changed?

Perhaps, in order to avoid breakage, we can include both for now, and retire itemId later? Could you update attack and damage rolls to include itemUuid as well?

I realise it would veer out of scope of the PR slightly, but I did so and added itemUuid to all other item roll types since those used itemId too. So in total, tool checks, other formula, attack, damage, and use.