Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set "cover" value for vehicle actions #4931

Open
TheGiddyLimit opened this issue Dec 27, 2024 · 0 comments · May be fixed by #4996
Open

Cannot set "cover" value for vehicle actions #4931

TheGiddyLimit opened this issue Dec 27, 2024 · 0 comments · May be fixed by #4996
Assignees
@arbron
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 4.2.0

Comments

@TheGiddyLimit
Copy link
Contributor

A "Cover" column is displayed under vehicle Features -> Actions, but there is no UI to set this value.

image

The MountableTemplate data model, which includes the cover field, is only mixed into weapon/equipment-type items, but neither of these allow the field to be set in the UI. Additionally, each of these have their own sheet header, neither of which have a "cover" column.

Exporting a working actor from dnd 3.3.1:

image

but when imported into dnd 4.1.2:

image

blanks the "Cover" display, and when exported from 4.1.2, the "cover" field is missing from the resulting JSON.

JSON exported from 3.3.1:

fvtt-Actor-test-vehicle-PaPE3J59L6Wcq8NN.json

JSON exported from 4.1.2:

fvtt-Actor-test-vehicle-T0Nk9Ntj3G34tDCY.json

Env:

  • dnd5e 4.1.2
  • Foundry 12.331
  • no modules active
@arbron arbron added the bug Functionality which is not working as intended label Jan 1, 2025
@arbron arbron added this to the D&D5E 4.2.0 milestone Jan 1, 2025
@arbron arbron self-assigned this Jan 13, 2025
arbron added a commit that referenced this issue Jan 13, 2025
@arbron
[#4929, #4931] Fix mountable data models, add cover to feat sheet
9486d21 
- Move `cover` from `MountableTemplate` to `FeatData` since feats
  are the only item type that display this data on vehicles
- Add "Vehicle Feature" type for features and display a cover
  field if this type is selected
- Remove `armor` from `MountableTemplate` and define directly on
  `WeaponData`, since `EquipmentData` already has armor
- Move to using localization prefixes for mountable labels
- Change cover labels shown on vehicle sheet to remove distinction
  between `0` and `null` values

Closes #4929
Closes #4931
@arbron arbron linked a pull request Jan 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

[#4929, #4931] Fix mountable data models, add cover to feat sheet foundryvtt/dnd5e
2 participants
@arbron @TheGiddyLimit