Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint compatibility issues with Node 19 #2091

Closed
arbron opened this issue Jan 22, 2023 · 3 comments · Fixed by #2092
Closed

ESLint compatibility issues with Node 19 #2091

arbron opened this issue Jan 22, 2023 · 3 comments · Fixed by #2092
Assignees
Milestone

Comments

@arbron
Copy link
Collaborator

arbron commented Jan 22, 2023

  • The version of eslint-plugin-jsdoc that is set up in package.json doesn't support Node 19.
  • gulp-estlint7 has been deprecated and replaced by gulp-eslint-new to support future versions of eslint
@arbron arbron self-assigned this Jan 22, 2023
@arbron arbron linked a pull request Jan 22, 2023 that will close this issue
@Fyorl
Copy link
Contributor

Fyorl commented Jan 23, 2023

Does gulp-eslint-new run correctly on Node 14 (the current minimum for v10)?

@arbron
Copy link
Collaborator Author

arbron commented Jan 23, 2023

Does gulp-eslint-new run correctly on Node 14 (the current minimum for v10)?

It supports Node 14 but strangely not Node 15. I don’t know what is going on with that. If that’s an issue we can remove that change and stick with just the plug-in version bump which was the one causing the install issues in Node 19.

@Fyorl
Copy link
Contributor

Fyorl commented Jan 23, 2023

It supports Node 14 but strangely not Node 15. I don’t know what is going on with that. If that’s an issue we can remove that change and stick with just the plug-in version bump which was the one causing the install issues in Node 19.

I can understand running an old LTS release, but it would be a bit strange to be running an old odd-numbered release. Still, if gulp-eslint7 is only deprecated, lets just keep using that for now, and bump all our dependencies once dnd5e does a minimum v11 release.

@arbron arbron added this to the D&D5E 2.1.3 milestone Jan 25, 2023
@arbron arbron closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants