Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crew and Passengers do not render on the Vehicle sheet. #2054

Closed
krbz999 opened this issue Jan 13, 2023 · 1 comment · Fixed by #2086
Closed

Crew and Passengers do not render on the Vehicle sheet. #2054

krbz999 opened this issue Jan 13, 2023 · 1 comment · Fixed by #2086
Assignees
@arbron
Labels
bug Functionality which is not working as intended ui User interface related features or bugs
Milestone
D&D5E 2.1.3

Comments

@krbz999
Copy link
Contributor

krbz999 commented Jan 13, 2023

image
@Fyorl Fyorl added bug Functionality which is not working as intended ui User interface related features or bugs labels Jan 13, 2023
@Fyorl Fyorl added this to the D&D5E 2.1.3 milestone Jan 13, 2023
@p4535992 p4535992 mentioned this issue Jan 15, 2023
Merged
@arbron
Copy link
Collaborator

arbron commented Jan 17, 2023

This is because handlebars doesn't render anything within the {{#with}} block if it doesn't have a value.

@arbron arbron self-assigned this Jan 17, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Jan 17, 2023
@arbron
[foundryvtt#2054] Fix crew & passengers sections not displaying on ve…
dfb4f43 
…hicle sheet
@arbron arbron mentioned this issue Jan 17, 2023
Merged
@arbron arbron linked a pull request Jan 17, 2023 that will close this issue
[#2055, #2057, #2058, #2066] Fix various issues with sheets #2072
Merged
@arbron arbron removed a link to a pull request Jan 20, 2023
[#2055, #2057, #2058, #2066] Fix various issues with sheets #2072
Merged
arbron added a commit to arbron/dnd5e that referenced this issue Jan 20, 2023
@arbron
[foundryvtt#2054] Fix crew & passengers sections not displaying on ve…
2e8c3bf 
…hicle sheet
@arbron arbron mentioned this issue Jan 20, 2023
Merged
@arbron arbron linked a pull request Jan 20, 2023 that will close this issue
[#2054] Fix crew & passengers sections not displaying on vehicle sheet #2086
Merged
Fyorl pushed a commit that referenced this issue Jan 23, 2023
@arbron @Fyorl
[#2054] Fix crew & passengers sections not displaying on vehicle sheet
b726751
@Fyorl Fyorl closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended ui User interface related features or bugs
Projects
None yet
Milestone
D&D5E 2.1.3
Development

Successfully merging a pull request may close this issue.

[#2054] Fix crew & passengers sections not displaying on vehicle sheet arbron/dnd5e
3 participants
@Fyorl @arbron @krbz999