Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize trait configuration #1885

Closed
arbron opened this issue Oct 21, 2022 · 0 comments · Fixed by #1886
Closed

Centralize trait configuration #1885

arbron opened this issue Oct 21, 2022 · 0 comments · Fixed by #1886
Assignees
@arbron
Labels
api
Milestone
D&D5E 2.1.0 - Dat...

Comments

@arbron
Copy link
Collaborator

arbron commented Oct 21, 2022 •
edited
Loading

Currently there is a bunch of logic for handling actor traits (weapon/armor/tool proficiencies, damage resistances, languages, etc.) that is spread throughout the code (some in ProficiencySelector, some in the actor document, some in the actor sheet application, some in templates) which makes it hard to reason about or modify the behavior of any individual trait. Centralizing this information in a config object would be great and a major boon for implementing #1405.

There should also be a merging of TraitSelector, ProficiencySelector, and DamageTraitSelector into a single application that is able to use this trait configuration data itself rather than requiring the choices list to be defined on the actor sheet.
@arbron arbron added the api label Oct 21, 2022
@arbron arbron added this to the D&D5E 2.1.0 milestone Oct 21, 2022
@arbron arbron self-assigned this Oct 21, 2022
arbron added a commit to arbron/dnd5e that referenced this issue Oct 21, 2022
@arbron
[foundryvtt#1885] Centralize trait configuration
d746964
arbron added a commit to arbron/dnd5e that referenced this issue Oct 21, 2022
@arbron
[foundryvtt#1885] Merge TraitSelector, ProficiencySelector, and Damag…
6b03a11 
…eTraitSelector into single app
arbron added a commit to arbron/dnd5e that referenced this issue Oct 21, 2022
@arbron
[foundryvtt#1885] Merge TraitSelector, ProficiencySelector, and Damag…
8a57ae9 
…eTraitSelector into single app
@arbron arbron linked a pull request Oct 21, 2022 that will close this issue
[#1885] Centralize trait configuration & merge TraitSelector applications #1886
Merged
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
@arbron
[foundryvtt#1885] Centralize trait configuration
0bcefa7
arbron added a commit to arbron/dnd5e that referenced this issue Dec 21, 2022
@arbron
[foundryvtt#1885] Merge TraitSelector, ProficiencySelector, and Damag…
2920f4f 
…eTraitSelector into single app
arbron added a commit to arbron/dnd5e that referenced this issue Dec 29, 2022
@arbron
[foundryvtt#1885] Centralize trait configuration
70f053e
arbron added a commit to arbron/dnd5e that referenced this issue Dec 29, 2022
@arbron
[foundryvtt#1885] Merge TraitSelector, ProficiencySelector, and Damag…
f0953e5 
…eTraitSelector into single app
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Centralize trait configuration
f751137
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Merge TraitSelector, ProficiencySelector, and Damag…
dcf9619 
…eTraitSelector into single app
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Remove old V9 code, fix a few issues
50cf836
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Centralize trait configuration
387758b
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Merge TraitSelector, ProficiencySelector, and Damag…
8b82d1e 
…eTraitSelector into single app
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Remove old V9 code, fix a few issues
5a50146
arbron added a commit to arbron/dnd5e that referenced this issue Jan 2, 2023
@arbron
[foundryvtt#1885] Remove old V9 code, fix a few issues
4476a49
Fyorl pushed a commit that referenced this issue Jan 2, 2023
@arbron
[#1885] Centralize trait configuration & merge TraitSelector applic…
6c5b986 
…ations (#1886)
@arbron arbron closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
api
Projects
None yet
Milestone
D&D5E 2.1.0 - Data Models
Development

Successfully merging a pull request may close this issue.

[#1885] Centralize trait configuration & merge TraitSelector applications arbron/dnd5e
1 participant
@arbron