Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for selection of skill ability on the character sheet #1852

Closed
Fyorl opened this issue Oct 7, 2022 · 1 comment
Closed

Allow for selection of skill ability on the character sheet #1852

Fyorl opened this issue Oct 7, 2022 · 1 comment
Assignees
Labels
api system: dice Dice rolling functionality ui User interface related features or bugs ux User experience related features or bugs
Milestone

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Oct 7, 2022

Being able to change the ability used for the skill check partway through the process causes some issues with our roll pipeline whereby we must revisit any ability check bonuses and modifiers after the intermediary dialog has been confirmed, rather than resolving these up-front.

If we move the ability selection to the sheet, we keep the flexibility of choosing an ability to use for the skill check, while also simplifying our roll pipeline as we can guarantee the ability used for the roll will not change partway though.

image

@Fyorl Fyorl added ui User interface related features or bugs api ux User experience related features or bugs system: dice Dice rolling functionality labels Oct 7, 2022
@Fyorl Fyorl added this to the D&D5E 2.1.0 milestone Oct 7, 2022
@Fyorl Fyorl self-assigned this Oct 7, 2022
Fyorl added a commit that referenced this issue Oct 7, 2022
…ather than during the intermediary roll dialog.
Fyorl added a commit that referenced this issue Oct 8, 2022
…ather than during the intermediary roll dialog.
@arbron arbron removed this from the D&D5E 2.1.0 milestone Jan 3, 2023
@Rabulias
Copy link

Unless I ma missing something in the request, I think this is done and can be closed? I am still on DND5E 2.4.1, and I can change the ability used on the sheets for long term, and skill check windows have a dropdown to select an ability score for a one off roll.

@arbron arbron added this to the D&D5E 3.0.0 milestone Mar 25, 2024
@arbron arbron closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api system: dice Dice rolling functionality ui User interface related features or bugs ux User experience related features or bugs
Projects
None yet
Development

No branches or pull requests

3 participants