Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_onCreateOwnedWeapon ignores provided proficiency value #1349

Closed
aaclayton opened this issue Nov 8, 2021 · 1 comment
Closed

_onCreateOwnedWeapon ignores provided proficiency value #1349

aaclayton opened this issue Nov 8, 2021 · 1 comment
Assignees
Labels
api bug Functionality which is not working as intended

Comments

@aaclayton
Copy link
Contributor

Originally in GitLab by @akrigline

When programattically creating a weapon item on a Character actor, the provided proficiency value is ignored by _onCreateOwnedWeapon if the item has a weaponType that the actor does not typically have proficiency with.

Example:

someActor.createEmbeddedDocuments("Item", [{
      "name": "Summoned Spiritual Weapon",
      "type": "weapon",
      "data": {
        "weaponType": "simpleM",
        "proficient": true
      }
    }]
  );

If proficient is provided, we should use the value provided instead of overriding it.

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @Fyorl

mentioned in commit 9fad980

jtljac pushed a commit to jtljac/me5e that referenced this issue Sep 20, 2022
…reating a weapon if a proficiency value was explicitly provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Functionality which is not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants