Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Support variables in Duration field of items #1334

Closed
aaclayton opened this issue Oct 14, 2021 · 2 comments
Closed

Suggestion: Support variables in Duration field of items #1334

aaclayton opened this issue Oct 14, 2021 · 2 comments
Labels
feature request mr fodder

Comments

@aaclayton
Copy link
Contributor

Originally in GitLab by @Mary-Usagi

It would be great if item sheets would support variables in the Duration field, like in the max value for Limited Uses.

image
@aaclayton
Copy link
Contributor Author

Straightforward request that makes sense to me. I hope we can pick this up for a future release.

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @kaelad

I'm going to give this a shot. Seems like an easy one for my first MR to the system.

Fyorl added a commit that referenced this issue Oct 19, 2022
@kaelad02 @Fyorl
[#1334] Support variables in Duration field of items (#1603)
93f9b7d 
Co-authored-by: Kim Mantas <kim.mantas@gmail.com>
@Fyorl Fyorl closed this as completed Oct 19, 2022
arbron pushed a commit to arbron/dnd5e that referenced this issue Oct 22, 2022
@kaelad02 @Fyorl @arbron
[foundryvtt#1334] Support variables in Duration field of items (found…
6b87203 
…ryvtt#1603)

Co-authored-by: Kim Mantas <kim.mantas@gmail.com>
arbron added a commit to arbron/dnd5e that referenced this issue Oct 26, 2022
@arbron
[foundryvtt#1334, foundryvtt#1835] Fix ActivatedEffectTemplate not al…
2288e48 
…lowing formulas for durations
arbron added a commit that referenced this issue Oct 26, 2022
@arbron
Merge pull request #1899 from arbron/data/duration-fix
be484ca 
[#1334, #1835] Fix ActivatedEffectTemplate not allowing formulas for durations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request mr fodder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fyorl @aaclayton