Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subclassing information to Class item #1017

Closed
arbron opened this issue Mar 2, 2021 · 4 comments · Fixed by #4072
Closed

Add subclassing information to Class item #1017

arbron opened this issue Mar 2, 2021 · 4 comments · Fixed by #4072
Assignees
Milestone

Comments

@arbron
Copy link
Collaborator

arbron commented Mar 2, 2021

Add an item to the Class template which indicates what level the class takes a subclass (3rd level for most classes, 1st for Clerics, 2nd for Wizards) and the custom name for that subclass (Arcane Tradition, Bardic College, Ranger Archetype).

{
  "subclass": {
    "name": "Ranger Archetype",
    "level": 3,
    "selected": "gloom-stalker"
  }
}

The name would allow for better customization of the UI per class.

The level data would allow for a theoretical future level-up interface to prompt the player to select a subclass when they reach the level that requires it.

This would replace the current subclass field, the value of which would be moved to subclass.selected.

@arbron
Copy link
Collaborator Author

arbron commented Mar 2, 2021

Originally in GitLab by @aaclayton

General proposal seems fair - I would suggest instead of selected perhaps id and instead of name going with label, i.e.

{
  "subclass": {
    "id": "gloom-stalker"
    "label": "Gloom Stalker",
    "level": 3,
  }
}

Perhaps I'm misunderstanding what you intend the subclass.name field to be used for?

@arbron
Copy link
Collaborator Author

arbron commented Mar 2, 2021

The name field was intended for customizing the UI for classes because each class names its subclasses differently (e.g. Artificer Specialist, Primal Path, Bard College, Divine Domain, Druid Circle, Martial Archetype, Monastic Tradition, Sacred Oath, Ranger Archetype, Roguish Archetype, Sorcerous Origin, Otherworldly Patron, Arcane Tradition).

image

This would add complications for localization being as it affects the interface. Perhaps for the SRD classes we could do a lookup in the localization file and then fallback if it is a custom class.

@arbron
Copy link
Collaborator Author

arbron commented Jul 10, 2021

Originally in GitLab by @iaguastalli

I am interested on this; mostly because I want to leverage the subclass level value to automate subclass selection. Is there any possibility of moving this forward ?

@arbron
Copy link
Collaborator Author

arbron commented Jul 10, 2021

Originally in GitLab by @aaclayton

There is definitely possibility of moving it forward, but not right now. Our focus is currently on %"D&D5E 1.4.0 - Armor Class Automation"

arbron added a commit that referenced this issue Aug 29, 2024
Introduces a new subclass advancement! This advancement doesn't do
anything on its own other than indicate the level at which the
class takes a subclass due to limitations in the advancement
system.

When a player reaches the level of the subclass advancement, their
features tab adds a "Add Subclass" button where the subclass icon
will eventually appear. Clicking this opens the compendium browser
with the subclass list locked to the current class's identifier.

While this doesn't fully implement what was originally desired
from the subclass advancement, this workflow should work pretty
well to fill in a major gap in the system's level-up workflow.

Closes #1017
Closes #1407
@arbron arbron self-assigned this Aug 29, 2024
@arbron arbron added this to the D&D5E 4.0.0 milestone Aug 29, 2024
@arbron arbron closed this as completed in 6f51195 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant