Skip to content

Add delete account feature to remove an account from the accounts file. #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
THenry14 merged 23 commits into from
Oct 23, 2023
Merged

Add delete account feature to remove an account from the accounts file. #743

THenry14 merged 23 commits into from
Oct 23, 2023

Conversation

@devnet0x
Copy link
Contributor

@devnet0x devnet0x commented Sep 27, 2023

Closes #498

Introduced changes

Add account delete feature to remove an account from a network in the accounts file.

Breaking changes

N/A

Checklist

  • [ X] Linked relevant issue
  • [ X] Updated relevant documentation
  • [ X] Added relevant tests
  • [ X] Performed self-review of the code
  • [ X] Added changes to CHANGELOG.md

@devnet0x devnet0x requested a review from a team as a code owner September 27, 2023 19:54
@devnet0x devnet0x requested review from THenry14 and drknzz and removed request for a team September 27, 2023 19:54
THenry14
THenry14 requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@THenry14 THenry14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good, thanks for an amazing contribution 💪 A few smaller things to change/add but apart from that good job!

One think I'd like you to also add is delete subcommand appendix in docs - with the description of its arguments etc. Something very similar to what's already done (you can find appendix pages for account command in docs/src/appendix/cast/account - you can add delete.md there :) )

@devnet0x @THenry14
Apply suggestions from code review
9c9fe87 
Co-authored-by: Wojciech Szymczyk <wojciech.szymczyk@swmansion.com>
@devnet0x devnet0x closed this Sep 29, 2023
@THenry14
Copy link
Collaborator

THenry14 commented Oct 2, 2023

Hi @devnet0x , was this closed on purpose?

@devnet0x
Copy link
Contributor Author

devnet0x commented Oct 2, 2023

Hi, no, i think it was my mistake

@devnet0x devnet0x reopened this Oct 2, 2023
@devnet0x devnet0x closed this Oct 3, 2023
@devnet0x devnet0x reopened this Oct 3, 2023
@devnet0x
Copy link
Contributor Author

devnet0x commented Oct 3, 2023

gm..al conversations solved, please recheck. Thanks.

THenry14
THenry14 requested changes Oct 4, 2023
View reviewed changes
drknzz
drknzz reviewed Oct 13, 2023
View reviewed changes
drknzz
drknzz reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great 👌 just some smaller changes

devnet0x and others added 4 commits October 18, 2023 15:28
@devnet0x @drknzz
Update docs/src/starknet/account.md
f0c736d 
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
@devnet0x @drknzz
Update docs/src/starknet/account.md
8f1f977 
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
@devnet0x @drknzz
Update crates/cast/src/main.rs
fa67062 
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
@devnet0x @drknzz
Update crates/cast/src/starknet_commands/account/delete.rs
c4e0253 
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
@devnet0x
Copy link
Contributor Author

devnet0x commented Oct 18, 2023

Thanks for your advice, conversations solved and changes commited.

drknzz
drknzz reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💯
Let's add the sections to the docs like in this pr before merging

@devnet0x
Copy link
Contributor Author

devnet0x commented Oct 20, 2023 •
edited
Loading

Done, please your review @drknzz

drknzz
drknzz approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

THenry14
THenry14 reviewed Oct 23, 2023
View reviewed changes
devnet0x and others added 2 commits October 23, 2023 09:42
@devnet0x @THenry14
Update crates/cast/src/starknet_commands/account/delete.rs
07d4802 
Fix prompt with a more clear message.

Co-authored-by: Wojciech Szymczyk <wojciech.szymczyk@swmansion.com>
@devnet0x
Merge branch 'foundry-rs:master' into master
0bcec42
THenry14
THenry14 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, thanks again for the contribution 🔥

@THenry14 THenry14 added this pull request to the merge queue Oct 23, 2023
Merged via the queue into foundry-rs:master with commit 41ffd30 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@THenry14 THenry14 THenry14 approved these changes

+1 more reviewer

@drknzz drknzz drknzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add account delete command

3 participants

@devnet0x @THenry14 @drknzz