Skip to content

Explicitly print full path of files edited by sncast account #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Explicitly print full path of files edited by sncast account #3376

merged 1 commit into from
May 22, 2025

Conversation

kkawula
Copy link
Contributor

@kkawula kkawula commented May 19, 2025 •
edited
Loading

Closes #3227

@kkawula kkawula requested a review from a team as a code owner May 19, 2025 13:20
@kkawula kkawula requested review from ddoktorski and franciszekjob and removed request for a team May 19, 2025 13:20
@kkawula kkawula mentioned this pull request May 19, 2025
Merged
@kkawula kkawula force-pushed the spr/master/0f91f073 branch from f565572 to 135dbf0 Compare May 19, 2025 13:24
@kkawula kkawula force-pushed the spr/master/1e7a71f0 branch 2 times, most recently from 792f241 to 0610f6f Compare May 19, 2025 13:26
@kkawula kkawula force-pushed the spr/master/0f91f073 branch 2 times, most recently from d92bf59 to 9a1a813 Compare May 19, 2025 13:28
@kkawula kkawula force-pushed the spr/master/1e7a71f0 branch from 0610f6f to be865ae Compare May 19, 2025 13:28
@kkawula kkawula force-pushed the spr/master/0f91f073 branch 2 times, most recently from 92d0410 to 342f0b7 Compare May 19, 2025 13:39
cptartur
cptartur reviewed May 20, 2025
View reviewed changes
@kkawula kkawula force-pushed the spr/master/0f91f073 branch from 342f0b7 to 927c503 Compare May 20, 2025 14:39
@kkawula kkawula requested a review from cptartur May 20, 2025 14:39
ddoktorski
ddoktorski requested changes May 20, 2025
View reviewed changes
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2025
@kkawula
Refactor cast config resolving (#3375)
06033ad 
**Stack**:
- #3376
- #3375 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/master/1e7a71f0 to master May 21, 2025 11:23
@kkawula kkawula force-pushed the spr/master/0f91f073 branch from 927c503 to 9709ec6 Compare May 21, 2025 17:33
@kkawula kkawula mentioned this pull request May 21, 2025
Closed
5 tasks
@kkawula kkawula force-pushed the spr/master/0f91f073 branch 4 times, most recently from da4725f to 4afe19e Compare May 21, 2025 17:46
@kkawula kkawula requested a review from ddoktorski May 21, 2025 17:47
@kkawula kkawula force-pushed the spr/master/0f91f073 branch from 4afe19e to f0e1a23 Compare May 21, 2025 17:51
@kkawula kkawula force-pushed the spr/master/0f91f073 branch from f0e1a23 to 5c0e053 Compare May 22, 2025 11:07
@kkawula kkawula requested a review from Copilot May 22, 2025 12:14
Copilot
Copilot AI reviewed May 22, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the output messages for profile creation commands by explicitly printing the full, canonicalized path of the configuration file. The changes include:

  • Updating test assertions in account import and create tests to verify the full path in stdout.
  • Introducing a new helper function, generate_add_profile_message, to consolidate profile message generation.
  • Refactoring account commands in both import and create modules to use the new helper function.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
crates/sncast/tests/e2e/account/import.rs Updated test to assert stdout contains the full canonical path
crates/sncast/tests/e2e/account/create.rs Updated test to assert stdout contains the full canonical path
crates/sncast/src/starknet_commands/account/mod.rs Added generate_add_profile_message helper for message creation
crates/sncast/src/starknet_commands/account/import.rs Refactored to use the new helper function instead of direct configuration update
crates/sncast/src/starknet_commands/account/create.rs Refactored to use the new helper function for generating profile messages

@kkawula kkawula added this pull request to the merge queue May 22, 2025
Merged via the queue into master with commit 995e7f8 May 22, 2025
65 of 100 checks passed
@kkawula kkawula deleted the spr/master/0f91f073 branch May 22, 2025 17:30
cptartur added a commit that referenced this pull request May 26, 2025
@cptartur
Mention #3376 in CHANGELOG.md
9970cbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ddoktorski ddoktorski ddoktorski approved these changes

@cptartur cptartur cptartur approved these changes

@franciszekjob franciszekjob Awaiting requested review from franciszekjob franciszekjob is a code owner automatically assigned from foundry-rs/starknet-foundry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explicitly print full path of files edited by sncast account import

3 participants

@kkawula @ddoktorski @cptartur