Fix type conversion in script "deploy" that resulted in max_fee being omitted #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptartur
requested review from
ddoktorski,
kkawula and
franciszekjob
as code owners
franciszekjob
approved these changes
Jan 29, 2025
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
This came up from #2865
Conversion from
ScriptFeeSettingstoFeeSettingsresulted in value formax_feebeing dropped completely. This conversion was only in cast script "deploy" function.If deploy was used with Strk token, any value passed to
max_feewas completely ignored.Removed the conversion entirely and used correct structure in deploy.
Checklist
CHANGELOG.md