Skip to content

Feat/generate default name on create #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Feb 7, 2025
Merged

Feat/generate default name on create #2883

merged 32 commits into from
Feb 7, 2025

Conversation

RichoKD
Copy link
Contributor

@RichoKD RichoKD commented Jan 27, 2025 •
edited
Loading

Resolves #2709

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@RichoKD RichoKD marked this pull request as ready for review January 27, 2025 16:39
franciszekjob
franciszekjob requested changes Jan 28, 2025
View reviewed changes
@franciszekjob
Copy link
Contributor

@RichoKD please resolve the conflicts so I can approve and run CI :)

@RichoKD RichoKD requested a review from franciszekjob January 28, 2025 13:04
franciszekjob
franciszekjob requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🙌 please address lest two changes and we should be good to go

@RichoKD RichoKD requested a review from franciszekjob January 29, 2025 08:41
franciszekjob
franciszekjob requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments and resolve the conflicts.

@RichoKD RichoKD requested a review from franciszekjob January 29, 2025 20:56
franciszekjob
franciszekjob requested changes Jan 29, 2025
View reviewed changes
@RichoKD RichoKD requested a review from franciszekjob January 30, 2025 06:18
franciszekjob
franciszekjob previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Please apply the suggestion and we should be good to go :)

@franciszekjob franciszekjob dismissed their stale review January 30, 2025 10:58

Docs need to be updated

franciszekjob
franciszekjob reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update docs: let's change Required to Optional for --name flag under https://github.com/foundry-rs/starknet-foundry/blob/master/docs/src/appendix/sncast/account/create.md#--name--n-account_name

cptartur
cptartur reviewed Jan 31, 2025
View reviewed changes
@RichoKD RichoKD requested a review from cptartur January 31, 2025 12:47
@RichoKD
Copy link
Contributor Author

RichoKD commented Feb 4, 2025

@franciszekjob I fixed the test

franciszekjob
franciszekjob approved these changes Feb 6, 2025
View reviewed changes
@franciszekjob franciszekjob requested a review from a team as a code owner February 6, 2025 16:47
@franciszekjob franciszekjob added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@cptartur cptartur added this pull request to the merge queue Feb 7, 2025
Merged via the queue into foundry-rs:master with commit 13514e7 Feb 7, 2025
38 checks passed
@RichoKD
Copy link
Contributor Author

RichoKD commented Feb 7, 2025

Thanks @franciszekjob @cptartur

@RichoKD RichoKD deleted the Feat/generate-name-on-create branch March 25, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski

@kkawula kkawula Awaiting requested review from kkawula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate default name while using account create
3 participants
@RichoKD @franciszekjob @cptartur