snforge_std: remove RevertedTransaction
#1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drknzz
force-pushed
the
1887-reverted-transaction
branch
from
83d922f to
c5ee788
Compare
drknzz
force-pushed
the
1887-reverted-transaction
branch
from
c5ee788 to
26783ad
Compare
drknzz
force-pushed
the
1894-deploy-syscallresult
branch
from
efee655 to
48232bb
Compare
drknzz
force-pushed
the
1894-deploy-syscallresult
branch
from
7ac9dc8 to
081f85a
Compare
drknzz
force-pushed
the
1887-reverted-transaction
branch
from
26783ad to
3ceef6d
Compare
drknzz
force-pushed
the
1887-reverted-transaction
branch
from
3ceef6d to
dcc018f
Compare
drknzz
changed the title
RevertedTransactionRevertedTransaction
Arcticae
reviewed
Apr 4, 2024
piotmag769
approved these changes
Apr 5, 2024
| @@ -20,7 +27,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| #### Changed | |||
|
|
|||
| - `read_txt` and `read_json` now supports `ByteArray` | |||
| - `snforge_std::declare` returns `Result<ContractClass, RevertedTransaction>` instead of `ContractClass` | |||
There was a problem hiding this comment.
We shouldn't modify our past changelog :/
There was a problem hiding this comment.
Agree.
This hasn't been released though, see v0.21.0 CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1887
Introduced changes
RevertedTransactionexecute()returnsSyscallResult<()>declare()returnsResult<ContractClass, Array<felt252>>Checklist
CHANGELOG.md