Skip to content

Remove ForgePrint #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 6, 2024
Merged

Remove ForgePrint #1659

merged 8 commits into from
Feb 6, 2024

Conversation

drknzz
Copy link
Contributor

@drknzz drknzz commented Feb 5, 2024 •
edited
Loading

Closes #1493

Introduced changes

  • remove ForgePrint together with IORuntimeExtension
  • use print!, println! macros instead
  • remove Debugging section in docs

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@drknzz drknzz marked this pull request as ready for review February 5, 2024 15:38
@drknzz drknzz requested a review from a team as a code owner February 5, 2024 15:38
@drknzz drknzz requested review from war-in, Draggu and Arcticae and removed request for a team February 5, 2024 15:38
war-in
war-in approved these changes Feb 5, 2024
View reviewed changes
piotmag769
piotmag769 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code, me happy

@drknzz drknzz added this pull request to the merge queue Feb 6, 2024
Merged via the queue into master with commit 00e126e Feb 6, 2024
@drknzz drknzz deleted the 1493-remove-forgeprint branch February 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

@Draggu Draggu Awaiting requested review from Draggu Draggu was automatically assigned from foundry-rs/starknet-foundry-forge

+1 more reviewer

@war-in war-in war-in approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ForgePrint Implement Display where needed, recommend using print macros for debugging
4 participants
@drknzz @Arcticae @piotmag769 @war-in