fix(trace): properly report fallback() fn
#9287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
yash-atreya
approved these changes
Nov 8, 2024
zerosnacks
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Nice! Small note in regards to test case completeness w/ JSON
@sakulstra would you mind double checking the proposed output format?
zerosnacks
reviewed
Nov 8, 2024
zerosnacks
approved these changes
Nov 8, 2024
|
looks fine to me, thanks a lot for looking into this! |
grandizzy
changed the title
fallback() fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #9115
Solution