fix: 4844 fee fixes #8963
Merged
fix: 4844 fee fixes #8963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
reviewed
Sep 26, 2024
zerosnacks
reviewed
Sep 26, 2024
3 tasks
zerosnacks
reviewed
Sep 27, 2024
zerosnacks
reviewed
Sep 27, 2024
|
Marking as blocked as it depends on alloy-rs/alloy#1389 |
zerosnacks
reviewed
Sep 27, 2024
…rr` value: ErrorResp(ErrorPayload { code: -32003, message: "Block `blob_versioned_hashes` is not supported before the Cancun hardfork", data: None })
mattsse
requested review from
DaniPopes,
klkvr,
grandizzy and
yash-atreya
as code owners
mattsse
commented
Sep 27, 2024
Comment on lines
1235
to
1237
| max_fee_per_blob_gas: max_fee_per_blob_gas | ||
| .or(env.block.get_blob_gasprice()) | ||
| .map(U256::from), |
There was a problem hiding this comment.
we only need to do this if the blob_versioned hashes are non zero, so we can do this with an or_else here
mattsse
commented
Sep 27, 2024
zerosnacks
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: alloy-rs/alloy#1371
because this will fail eth_call/estimate if the request contains blob version hashes but we don't set a blob price in the txenv:
https://github.com/foundry-rs/foundry/blob/master/crates/anvil/src/eth/backend/mem/mod.rs#L1235-L1235
needs test case from alloy-rs/alloy#1371