Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anvil): remove old ethers-dependent anvil core types #6842

Merged
merged 11 commits into from
Jan 19, 2024
Merged

feat(anvil): remove old ethers-dependent anvil core types #6842

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
663e8f9
feat: remove most ethers and old anvil core types
Evalir Jan 18, 2024
03926e4
chore: replace handles for providers constructed on actual tests
Evalir Jan 18, 2024
33dbc40
finish moving test providers
Evalir Jan 18, 2024
66caede
chore: switch to decode_revert
Evalir Jan 18, 2024
3e9bf54
chore: replace with maybe_decode_revert
Evalir Jan 18, 2024
746a33f
u256::decode
Evalir Jan 18, 2024
769fe4e
chore: move all of anvil but tests and block subscriptions off ethers
Evalir Jan 18, 2024
9e52f1c
re-enable opt
Evalir Jan 18, 2024
3948ac2
solve nits
Evalir Jan 18, 2024
650af3a
chore: remove more println
Evalir Jan 18, 2024
39905df
chore: rename to gen
Evalir Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions crates/anvil/src/eth/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//! Aggregated error type for this module

use crate::eth::pool::transactions::PoolTransaction;
use alloy_dyn_abi::DynSolType;
use alloy_primitives::{Bytes, SignatureError as AlloySignatureError, U256};
use alloy_signer::Error as AlloySignerError;
use alloy_transport::TransportError;
Expand Down Expand Up @@ -266,10 +265,7 @@ pub(crate) fn decode_revert_reason(out: impl AsRef<[u8]>) -> Option<String> {
if out.len() < SELECTOR_LEN {
return None
}
DynSolType::String
.abi_decode(&out[SELECTOR_LEN..])
.ok()
.and_then(|v| v.as_str().map(|s| s.to_owned()))
Some(foundry_evm::decode::decode_revert(&out[SELECTOR_LEN..], None, None))
}

/// Helper trait to easily convert results to rpc results
Expand Down
Loading