fix(invariants): respect fail_on_revert properly and do not populate logs/traces twice
#6199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 2, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
can you get a repro for this as an additional test?
all of this feels like open heart surgery all the time
Member
Author
|
yep will do—just haven't finished adding the test :D |
2 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5726, fixes #6082, fixes #6024
fail_on_revertwas not getting respected correctly after a recent refactor, in which we stopped populating theerrorinInvariantFailures. This was causing mainly failures in handlers to not be detected leading to erroneous[PASS]states.We were also collecting the logs and traces of the last error twice, which is not necessary as we replay the entire run. This could lead to situations where it seems an invariant gets called twice, but it's just the error log popping up twice.