feat(forge): partial forge migration
#5873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
changed the title
forge): partial alloy primitives migrationforge): partial forge migration
Evalir
commented
Sep 21, 2023
| use alloy_primitives::{Address, Bytes, U256}; | ||
| use ethers_addressbook::contract; | ||
| use ethers_core::types::*; | ||
| use ethers_core::types::{BlockId, Chain, NameOrAddress}; |
Member
Author
There was a problem hiding this comment.
Wonder what we wanna do with this BlockId type? We also have BlockNumber which is a loosely related struct and I feel we could do some type consolidation. This probably concerns rpc types
mattsse
approved these changes
Sep 22, 2023
| /// A collection of [HitMap]s | ||
| #[derive(Default, Clone, Debug)] | ||
| pub struct HitMaps(pub HashMap<H256, HitMap>); | ||
| pub struct HitMaps(pub HashMap<B256, HitMap>); |
Member
There was a problem hiding this comment.
why are we using B256 now?
isn't there an alias for H256?
this can be super confusing
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
H stands for Hash which we moved away from months ago :)
Member
Author
There was a problem hiding this comment.
yep, @mattsse i think the alias might be local to reth if you're using that there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates forge's primitive types to alloy. Types remaining from
ethersaresolc,etherscanandrpcrelated unless highlighted for discussion.