chore: bump revm #5792
Merged
chore: bump revm #5792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Sep 6, 2023
Contributor
|
Just to link the original change: bluealloy/revm#71 . it seems that the problem was with returning U256::ZERO so returning just a number back seems okay. |
DaniPopes
force-pushed
the
bump-revm
branch
3 times, most recently
from
c7bac6d to
325dd33
Compare
Evalir
approved these changes
Sep 8, 2023
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
this lgtm!
what was the issue with the change that dragan posted?
Member
Author
|
@Evalir this discussion: bluealloy/revm#691 (comment) |
Member
Author
|
Yes |
mikelodder7
pushed a commit
to LIT-Protocol/foundry
that referenced
this pull request
Sep 12, 2023
* chore: bump revm * chore: update env chain ID to u64 * chore: drop fork * fix tests * bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bump to latest master
Also to run tests for bluealloy/revm#691
Relevant PRs:
CfgEnv.chain_idshould beu64bluealloy/revm#693Solution