chore: avoid cloning CompileOutput to parse inline config
#5683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
opt-inlinecfg
branch
from
88c3ad6 to
1f7705f
Compare
mikelodder7
pushed a commit
to LIT-Protocol/foundry
that referenced
this pull request
Sep 12, 2023
…rs#5683) * chore: avoid cloning `CompileOutput` to parse inline config * chore: clippy * use new solc methods * chore: bump ethers * chore: clippy * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cloning = slow
Cloning compiler output (TWICE) = incredibly slow
Please do not do this :)
We're talking 150ms for a
forge initproject, going into the seconds PER CLONE for big projects.Benchmarked with
AMD Ryzen 9 5900X (24) @ 3.700GHzSolution
Don't clone