Skip to content

fix(foundryup): check if file exists before moving #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(foundryup): check if file exists before moving #5662

merged 1 commit into from
Aug 18, 2023

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 18, 2023 •
edited
Loading

Motivation

Fixes #5658

Actually tested now

Solution

@DaniPopes DaniPopes marked this pull request as draft August 18, 2023 17:56
@DaniPopes DaniPopes marked this pull request as ready for review August 18, 2023 18:06
mattsse
mattsse approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty champ!

@mattsse mattsse merged commit 2b668d9 into foundry-rs:master Aug 18, 2023
@DaniPopes DaniPopes deleted the foundryup2 branch August 18, 2023 18:09
mikelodder7 pushed a commit to LIT-Protocol/foundry that referenced this pull request Sep 12, 2023
@DaniPopes @mikelodder7
fix(foundryup): check if file exists before moving (foundry-rs#5662)
d402fc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

foundryup fails when building from specific commit or branch

2 participants

@DaniPopes @mattsse