Skip to content

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 18, 2023

Motivation

Make CI better

Solution

  • generate test matrices programmatically with a script
  • build ALL tests once per target, instead of multiple times with features / individual packages. Remove external-integration-tests feature, since we can just filter better instead of having to recompile
  • improve test filters and partitions
  • remove useless (I think, please correct me if I'm wrong) install-svm-solc job
  • run the heavy integration tests with --release. This might be slower

@DaniPopes DaniPopes force-pushed the better-ci branch 7 times, most recently from 59d45da to 4d64799 Compare August 18, 2023 18:33
@DaniPopes DaniPopes marked this pull request as ready for review August 18, 2023 18:42
@Evalir
Copy link
Member

Evalir commented Aug 18, 2023

build ALL tests once per target, instead of multiple times with features / individual packages. Remove external-integration-tests feature, since we can just filter better instead of having to recompile

huge fan

remove useless (I think, please correct me if I'm wrong) install-svm-solc job

Yeah i think it ended up being useless. We ideally wanted it as a cache step but it didn't really help at all due to the ci structure

run the heavy integration tests with --release. This might be slower

Yeah might be slower, but hopefully it should be OK if the runtime is still less than an hour

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@Evalir Evalir merged commit d58ee4e into foundry-rs:master Aug 18, 2023
@DaniPopes DaniPopes deleted the better-ci branch August 18, 2023 20:09
mikelodder7 pushed a commit to LIT-Protocol/foundry that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants