Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fixing etherscan verify #354

Closed
wants to merge 1 commit into from
Closed

WIP: fixing etherscan verify #354

wants to merge 1 commit into from

Conversation

gakonst
Copy link
Member

@gakonst gakonst commented Jan 1, 2022

Depends on gakonst/ethers-rs#755. Does not work yet, because it requires us supporting file flattening or multiple files on ethers-etherscan.

Etherscan verification as-is right now is completely broken

@gakonst
Copy link
Member Author

gakonst commented Jan 13, 2022

Should be able to make progress here once gakonst/ethers-rs#774 is merged

@onbjerg onbjerg added the T-bug Type: bug label Jan 26, 2022
@tarrencev
Copy link
Contributor

tarrencev commented Jan 31, 2022

@gakonst anything i can help with here?

@gakonst
Copy link
Member Author

gakonst commented Jan 31, 2022

I'd coordinate with @rkrasiuk who's been on top of it on ethers-rs flattening

@rkrasiuk
Copy link
Collaborator

rkrasiuk commented Jan 31, 2022

@tarrencev here is the way we are moving forward:

  1. we need to merge Change artifact naming conventions #809
  2. fix/etherscan verification #828 uses the results of prev PR to pick up compiler version and num of optimizations
  3. and then we can make some progress on this PR

@tarrencev
Copy link
Contributor

@tarrencev here is the way we are moving forward:

  1. we need to merge Change artifact naming conventions #809
  2. fix/etherscan verification #828 uses the results of prev PR to pick up compiler version and num of optimizations
  3. and then we can make some progress on this PR

sweet! let me know if there is anything i can help with

@gakonst
Copy link
Member Author

gakonst commented Feb 4, 2022

@rkrasiuk the ethers PR is merged and as discussed we can do the auto version/opti runs detection after @mattsse's cache PR is merged.

Up to you if you wanna continue from this PR, or start fresh and maybe cherry pick any relevant code you find useful?

Very excited to get this over the line..

@rkrasiuk
Copy link
Collaborator

rkrasiuk commented Feb 4, 2022

@gakonst sounds good. i'd def cherry pick some changes from this PR. excited as well!

@gakonst gakonst closed this Feb 4, 2022
@gakonst gakonst deleted the fix/contract-verify branch February 4, 2022 09:13
@gakonst gakonst restored the fix/contract-verify branch February 4, 2022 09:13
@gakonst gakonst deleted the fix/contract-verify branch February 18, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants