Skip to content

Conversation

wellnana
Copy link
Contributor

@wellnana wellnana commented Oct 6, 2025

Closes #11979,

Automatic installation of Soldeer dependencies when forge install is run, if soldeer.lock file is detected in the installed dependency, it will run forge soldeer install in that dependency's directory to install via soldeer.

Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the ci failure, one of the failures is related to the block_on being used here

@onbjerg onbjerg self-assigned this Oct 7, 2025
@wellnana wellnana requested a review from onbjerg October 7, 2025 16:29
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes makes sense to me

pending @onbjerg's review

@onbjerg onbjerg merged commit bb80198 into foundry-rs:master Oct 7, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat(forge install): forge install should install the soldeer dependencies of installed dependencies

3 participants