Skip to content

Conversation

silvekkk
Copy link
Contributor

@silvekkk silvekkk commented Oct 3, 2025

found this while #11939 —the repros::issue_4640 test keeps failing all 3 retry attempts in CI.

Turns out it relies on Arbitrum RPC returning l1BlockNumber in the block response, but the endpoint doesn't always include it. When it's missing, we get L2 block 75219831 instead of the expected L1 block 16939475.

can't depend on that field being there. Ignoring it like issue_3703 for flaky Polygon RPCs.

// https://github.com/foundry-rs/foundry/issues/4640
test_repro!(4640);
test_repro!(
#[ignore = "flaky Arbitrum RPC - l1BlockNumber field not always returned"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use vm.createSelectFork("arbitrum") since we have better rpc urls for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaniPopes Got it - should I change the test to use vm.createSelectFork("arbitrum") without a block number? If so, what should the assertion verify?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm it already does that, this is fine i think

@DaniPopes
Copy link
Member

It's ok, if it fails we can re-run, it shouldnt happen that often that all retries fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants