Skip to content

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Oct 1, 2025

Motivation

  • solc_version is a backward compatible config (replaced by solc) and removed from dict, should not warn if in config
    } else if let Some(v) = dict.remove("solc_version") {
    // only insert older variant if not already included
    if !dict.contains_key("solc") {
    dict.insert("solc".to_string(), v);
    }

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy changed the title fix(forge): do not warn on backward compatible solc_version key fix(forge): do not warn on backward compatible solc_version config Oct 1, 2025
@grandizzy grandizzy marked this pull request as ready for review October 1, 2025 19:40
@grandizzy grandizzy enabled auto-merge (squash) October 1, 2025 19:46
@grandizzy grandizzy merged commit bd0e4a7 into foundry-rs:master Oct 1, 2025
40 of 44 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants