feat(fmt): solar bump + handle cmnts in non-informed params #11901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b58987.
0xrusowsky
requested review from
DaniPopes,
grandizzy,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
DaniPopes
previously approved these changes
Oct 1, 2025
|
also closes #11668 because of the compilers + solar bump |
DaniPopes
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
bumps solar version + closes: #11836
Solution
leverage the new
SpannedOption<T>to print comments between commas of non-informed elementsBlocked by
PR Checklist