Skip to content

fix: remove explicit darwin SDK from flake.nix as it's deprecated #11684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

fix: remove explicit darwin SDK from flake.nix as it's deprecated #11684

merged 1 commit into from
Sep 17, 2025

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Sep 17, 2025 •
edited
Loading

Motivation

Closes #11683

Solution

From https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks:

If your derivation references them, you can delete them. The default SDK should be enough to build your package.

❯ nix develop -c echo Ok
warning: Git tree '/Users/shekhirin/projects/oss/foundry' has uncommitted changes
Ok

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes enabled auto-merge (squash) September 17, 2025 14:08
zerosnacks
zerosnacks approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zerosnacks zerosnacks added the A-ci Area: CI label Sep 17, 2025
@DaniPopes DaniPopes merged commit 793ac48 into foundry-rs:master Sep 17, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

A-ci Area: CI

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(ci): nix workflow fails to run on macos-latest

4 participants

@shekhirin @onbjerg @DaniPopes @zerosnacks