feat(anvil): calculate max_transactions based on block gas capacity #11670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forkfury
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
mattsse
requested changes
Sep 16, 2025
This reverts commit 7c7bd60.
|
Alright, you definitely know better. Reverted my impementation and only deleted TODO |
mattsse
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded
max_transactions: 1_000with dynamic calculation based on block gas limit.Changes
calculate_max_transactions_from_gas_limit()functionmax_transactionswhen gas limit changesTechnical Details
gas_limit / 21_000(min transaction gas)