chore(common): deprecate ProjectCompiler::verify and fix compile_target docs #11636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radik878
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
onbjerg
requested changes
Sep 15, 2025
Yes ser, done |
onbjerg
requested changes
Sep 15, 2025
Yes, done |
onbjerg
approved these changes
Sep 15, 2025
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
…et docs (foundry-rs#11636) * chore(common): deprecate ProjectCompiler::verify and fix compile_target docs * fmt * Update compile.rs * fmt * Update compile.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile_target doc incorrectly referenced a verify behavior that is not implemented in this helper. Verification is performed by higher-level commands (e.g., forge create/script), not during compilation. Also, ProjectCompiler::verify was an unused/no-op flag; it is now deprecated with a clarifying doc to prevent confusion for downstream users.