-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(cheats): preserve struct order when parsing JSON objects #11612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2025
…sorted-json-w-compiler
DaniPopes
previously requested changes
Sep 24, 2025
DaniPopes
reviewed
Oct 3, 2025
DaniPopes
reviewed
Oct 6, 2025
DaniPopes
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Historical limitation in
vm.parseJson
where JSON object fields had to be sorted alphabetically, breaking compatibility with Solidity struct field order. This required developers to work around the limitation by manually ordering JSON fields.Solution
Integrate Solar's compiler output into the multi-runners. The PR introduces a
CheatcodeAnalysis
architecture that provides the cheatcode inspector access to Solar's compiler output, enabling order-preserving JSON parsing.JSON cheats improvements
parseJson
andparseJsonType
now use struct definitions to preserve field orderCheatcodeAnalysis Architecture
New
CheatcodeAnalysis
struct that provides cached, on-demand access to Solar's compiler output:the impl aims to be:
CheatcodeAnalysis
struct with the new fields and getter methodsintegrating a new analysis tool only requires setting up a new getter method (besides its impl):
note:
StructDefinitionResolver
is a HIR visitorold disc: