Fix CRLF line ending handling in stdin utilities #11606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in
crates/common/src/io/stdin.rs
where reading from stdin withread_line=true
would leave trailing\r
characters when processing CRLF line endings (Windows-style).Problem:
read_bytes(true)
only removed\n
but left\r
from CRLF sequencesunwrap_line()
,parse_line()
, etc.Solution:
\r
after\n
inread_bytes(true)
\n
) and CRLF (\r\n
) line endings