feat(coverage): analyze with solar #11565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `++i` line was reported first, so with the old check all previous lines were ignored. Now we track all lines regardless, so this change is more correct.
Fixes branch_with_calldata_reads test.
DaniPopes
commented
Sep 12, 2025
Comment on lines
+221
to
+222
| }, | ||
| stmt.span, |
There was a problem hiding this comment.
this is not entirely equivalent, but the previous logic resulted in weird spans for else-if chains (left is before, right is after):
this was added in #3094
If statements like `if (x) return y;` were missed by the previous `has_statements` function.
Same as previous test with `return`.
DaniPopes
requested review from
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
onbjerg
approved these changes
Sep 15, 2025
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
* feat(coverage): analyze with solar * chore: walk stmts normally, sort items * wip * chore: display all items with relevant source in debug format * wip * upd * chore: clippy * test: update do_while_lcov The `++i` line was reported first, so with the old check all previous lines were ignored. Now we track all lines regardless, so this change is more correct. * fix: legacy: do not recurse into emit, revert Fixes branch_with_calldata_reads test. * correct span * fix: inline config path * fix: resolve function kinds, ignore type conversions / struct ctors * fix: walk only functions * fix: push stmt for yul stmt expr early * test: add a test case for if (..) return If statements like `if (x) return y;` were missed by the previous `has_statements` function. * test: hoist contract instantiations out of test fns * test: add test case for single if with continue/break Same as previous test with `return`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10964.
By using Solar to analyze contracts to find items we can avoid requesting AST output from solc, saving a considerable amount of serde time.
This also fixes a few bugs, while trying to remain 100% compatible with the previous solc AST implementation. See individual commits and their descriptions for more details.
Default project:
ithacaxyz/account:
