Skip to content

Conversation

aganisgash
Copy link
Contributor

Replaces the temporary file deletion workaround in init_an_empty_project with a proper --no-example flag for forge init.

Fixes the TODO mentioned in clone.rs:171-172.

Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me.

can you fix the CI errors though?

@aganisgash
Copy link
Contributor Author

makes sense to me.

can you fix the CI errors though?

The CI is good now

Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit, can we make the flag name --empty? --no-example is quite long

@aganisgash
Copy link
Contributor Author

smol nit, can we make the flag name --empty? --no-example is quite long

Why not? Renamed!

@aganisgash aganisgash requested a review from onbjerg September 5, 2025 15:56
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending others

@DaniPopes DaniPopes changed the title feat: add example control flag to forge init feat(forge): add --empty to forge init Sep 5, 2025
Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@onbjerg onbjerg merged commit 05d4a02 into foundry-rs:master Sep 5, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Sep 5, 2025
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
* add example control

* fix CI

* 'no_example' -> 'empty'

---------

Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants