-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(forge): add --empty to forge init #11554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me.
can you fix the CI errors though?
The CI is good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol nit, can we make the flag name --empty
? --no-example
is quite long
Why not? Renamed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
* add example control * fix CI * 'no_example' -> 'empty' --------- Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
Replaces the temporary file deletion workaround in
init_an_empty_project
with a proper--no-example
flag forforge init
.Fixes the TODO mentioned in
clone.rs:171-172
.