feat: switch solar_project to use cache #11481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to solc when compiling involves parsing and analysis, which is the minimum work the compiler will do if nothing is requested, but this is still slow on the order of 100s of ms to a few seconds. We want to avoid this as much as possible because it's completely unused, as we're requesting nothing and we just want to run the pipeline to get the in-memory
solar
compiler from the output.Together with updating foundry-compilers for a cache bug fix (foundry-rs/compilers#312), this makes
solar_project
almost never call to solc.Currently only used by
forge eip712
(#11458), but will see more usage with #11456.