Skip to content

fix(coverage): contracts by artifact from linked contracts #11440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

fix(coverage): contracts by artifact from linked contracts #11440

merged 1 commit into from
Aug 27, 2025

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Aug 27, 2025 •
edited
Loading

Motivation

Solution

  • introduce builder to create ContractsByArtifact from contracts iter and enrich with storage layouts (if available)

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review August 27, 2025 10:56
yash-atreya
yash-atreya approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

0xrusowsky
0xrusowsky approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

probably a good reason to eventually work on adding coverage to the benchmarks

@grandizzy
Copy link
Collaborator Author

lgtm!

probably a good reason to eventually work on adding coverage to the benchmarks

yeah, I think that's more about missing unit test for common coverage case, should be added now

@grandizzy grandizzy merged commit 6e6341b into foundry-rs:master Aug 27, 2025
22 checks passed
@grandizzy grandizzy deleted the issue-11432 branch August 27, 2025 11:46
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 27, 2025
@yash-atreya yash-atreya mentioned this pull request Aug 29, 2025
Merged
3 tasks
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
@grandizzy @MerkleBoy
fix(coverage): contracts by artifact from linked contracts (foundry-r…
799bb58 
…s#11440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xrusowsky 0xrusowsky 0xrusowsky approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

+1 more reviewer

@yash-atreya yash-atreya yash-atreya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Coverage is significantly reduced after upgrade to nightly version

4 participants

@grandizzy @yash-atreya @0xrusowsky @zerosnacks