fix(forge script): repeated vm.createSelectFork with same RPC causes segfault
#11250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
yash-atreya
as code owners
yash-atreya
approved these changes
Aug 8, 2025
grandizzy
pushed a commit
to grandizzy/foundry
that referenced
this pull request
Aug 9, 2025
grandizzy
added a commit
that referenced
this pull request
Aug 9, 2025
* fix(fmt): don't panic on stdin read failure (#11226) * fix(`forge script`): repeated `vm.createSelectFork` with same RPC causes segfault (#11250) --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #11213
Solution
Pins revm to https://github.com/bluealloy/revm/tree/interpreter-is-end-flag which includes a fix for code that previously segfaulted
Bumping to revm 28 requires more work due to boxing changes in revm-inspectors, ref: #11217
PR Checklist