Skip to content

Conversation

Forostovec
Copy link
Contributor

The wallet list command was missing the call to list GCP signers, causing
the --gcp and --all flags to not display GCP accounts even when properly
configured.

  • Added list_senders!(list_opts.gcp_signers(), "GCP") call
  • Now --gcp flag properly lists GCP KMS accounts
  • Now --all flag includes GCP accounts when gcp-kms feature is enabled
  • Maintains consistency with existing Ledger, Trezor, and AWS listing

Fixes the issue where GCP accounts were never displayed despite having
the --gcp flag and proper environment variables configured.

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@grandizzy grandizzy merged commit d24e733 into foundry-rs:master Aug 9, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 9, 2025
@Forostovec Forostovec deleted the fix/cast-wallet-list-gcp-support branch September 7, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants