Skip to content

Conversation

yash-atreya
Copy link
Contributor

@yash-atreya yash-atreya commented Aug 5, 2025

Motivation

Ref #9504

Solution

  • Breaking: Add oldNonce and newNonce fields to the vm.AccountAccess struct
  • update the values in the Cheatcodes inspector in create, create_end, call and call_end.
  • Add NonceDiff to the AccountStateDiff such that vm.getStateDiff and vm.getStateDiffJson output now includes the "nonceDiff".
  • update tests accordingly

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya added C-forge Command: forge A-cheatcodes Area: cheatcodes T-likely-breaking Type: requires changes that can be breaking labels Aug 5, 2025
@yash-atreya yash-atreya marked this pull request as ready for review August 5, 2025 23:58
@yash-atreya yash-atreya self-assigned this Aug 12, 2025
@yash-atreya yash-atreya moved this to Ready For Review in Foundry Aug 12, 2025
@yash-atreya yash-atreya added this to the v1.4.0 milestone Aug 12, 2025
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yash-atreya yash-atreya merged commit f0c491b into master Aug 12, 2025
22 checks passed
@yash-atreya yash-atreya deleted the yash/nonce-diffs branch August 12, 2025 07:17
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry Aug 12, 2025
grandizzy added a commit to foundry-rs/forge-std that referenced this pull request Aug 12, 2025
support the new cheatcodes added in
foundry-rs/foundry#11236
support new nonce diffs added in
foundry-rs/foundry#11215

---------

Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
@grandizzy grandizzy removed the status in Foundry Aug 18, 2025
@grandizzy grandizzy moved this to Completed in Foundry Aug 18, 2025
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
…11215)

* feat(`cheatcodes`): add nonce diffs to AccountStateDiffs

* fmt

* fix test Issue9643Test

* fix
aubBrooks919 added a commit to aubBrooks919/forge-std that referenced this pull request Sep 25, 2025
support the new cheatcodes added in
foundry-rs/foundry#11236
support new nonce diffs added in
foundry-rs/foundry#11215

---------

Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
davidLong89 added a commit to davidLong89/forge-std that referenced this pull request Sep 25, 2025
support the new cheatcodes added in
foundry-rs/foundry#11236
support new nonce diffs added in
foundry-rs/foundry#11215

---------

Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cheatcodes Area: cheatcodes C-forge Command: forge T-likely-breaking Type: requires changes that can be breaking

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants