Skip to content

feat(anvil): added anvil_impersonateSignature #11195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 12, 2025
Merged

feat(anvil): added anvil_impersonateSignature #11195

merged 16 commits into from
Aug 12, 2025

Conversation

Soubhik-10
Copy link
Contributor

@Soubhik-10 Soubhik-10 commented Aug 4, 2025 •
edited
Loading

closes #5381

mattsse
mattsse requested changes Aug 4, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great,

as an example test we want a basic function that uses ecrecover that then asserts that the result is the fake address that we installed before invoking this function

@Soubhik-10 Soubhik-10 changed the title feat(anvil): added anvil recover sig feat(anvil): added anvilRecoverSignature Aug 6, 2025
@Soubhik-10 Soubhik-10 marked this pull request as ready for review August 6, 2025 12:19
@Soubhik-10 Soubhik-10 requested a review from mattsse August 6, 2025 12:33
mattsse
mattsse requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

@Soubhik-10 Soubhik-10 changed the title feat(anvil): added anvilRecoverSignature feat(anvil): added anvilImpersonateSignature Aug 7, 2025
@Soubhik-10 Soubhik-10 changed the title feat(anvil): added anvilImpersonateSignature feat(anvil): added anvil_impersonateSignature Aug 7, 2025
@Soubhik-10 Soubhik-10 requested a review from mattsse August 7, 2025 12:46
mattsse
mattsse requested changes Aug 8, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last tiny nit

@Soubhik-10 Soubhik-10 requested a review from mattsse August 8, 2025 13:17
mattsse
mattsse requested changes Aug 11, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last tiny nit

@Soubhik-10
Copy link
Contributor Author

Soubhik-10 commented Aug 12, 2025 •
edited
Loading

last tiny nit

wb ser

@Soubhik-10 Soubhik-10 requested a review from mattsse August 12, 2025 03:06
@mattsse mattsse merged commit 094a2c3 into foundry-rs:master Aug 12, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 12, 2025
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
@Soubhik-10 @MerkleBoy
feat(anvil): added anvil_impersonateSignature (foundry-rs#11195)
84f17c3 
* wip

* wip

* wip

* wip

* test

* clippy

* fixes

* removed checks

* extra check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add anvil_recoverSignature

2 participants

@Soubhik-10 @mattsse