chore: clean up cheatcode assertions #11161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
DaniPopes
commented
Jul 30, 2025
|
|
||
| impl_assertions! { | ||
| |left, right| assert_not_eq( | ||
| &left.iter().map(hex::encode_prefixed).collect::<Vec<_>>(), |
There was a problem hiding this comment.
these are now Bytes which do that by default in Display so we don't need to special case anymore
Make them faster and smaller in code size
DaniPopes
force-pushed
the
dani/cheat-assertions-cleanup
branch
from
2a10c8f to
acc1496
Compare
mattsse
approved these changes
Jul 30, 2025
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
* chore: clean up cheatcode assertions Make them faster and smaller in code size * invert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make them faster and smaller in code size