Skip to content

fix(cast): unknown signatures are cached as an empty string #11127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2025
Merged

fix(cast): unknown signatures are cached as an empty string #11127

merged 3 commits into from
Jul 28, 2025

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jul 28, 2025 •
edited
Loading

Motivation

Closes: #11125

Solution

Make sure signatures are not returned empty, previously we were caching empty results ("") preventing refetching.

The query returned as follows:

query: [Error(0x37d01491)]
res: [[]]
len(res): 1

meaning 0x37d01491 got paired with [], yielding empty "" string when written to cache

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks marked this pull request as ready for review July 28, 2025 12:32
@zerosnacks zerosnacks added C-cast Command: cast T-bug Type: bug labels Jul 28, 2025
grandizzy
grandizzy approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@zerosnacks zerosnacks merged commit 88b14a1 into master Jul 28, 2025
22 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/fix-cast-signature-cache branch July 28, 2025 12:48
@github-project-automation github-project-automation bot moved this to Done in Foundry Jul 28, 2025
zerosnacks added a commit that referenced this pull request Jul 29, 2025
@zerosnacks
Revert "fix(cast): unknown signatures are cached as an empty string (…
40d311d 
…#11127)"

This reverts commit 88b14a1.
This was referenced Jul 29, 2025
Merged
Open
zerosnacks added a commit that referenced this pull request Jul 29, 2025
@zerosnacks
Revert "fix(cast): unknown signatures are cached as an empty string" (
e653dbf 
#11140)

Revert "fix(`cast`): unknown signatures are cached as an empty string (#11127)"

This reverts commit 88b14a1.
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
@zerosnacks @MerkleBoy
fix(cast): unknown signatures are cached as an empty string (foundr…
0c8ba20 
…y-rs#11127)

* make sure signatures are not empty, previously we were caching empty results ("") preventing refetching

* add tests

* avoid duplicate code
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
@zerosnacks @MerkleBoy
Revert "fix(cast): unknown signatures are cached as an empty string" (
6cc7c95 
foundry-rs#11140)

Revert "fix(`cast`): unknown signatures are cached as an empty string (foundry-rs#11127)"

This reverts commit 88b14a1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grandizzy grandizzy grandizzy approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya

Assignees

No one assigned

Labels

C-cast Command: cast T-bug Type: bug

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unknown signatures are cached as an empty string

2 participants

@zerosnacks @grandizzy