Skip to content

Conversation

DaniPopes
Copy link
Member

Reduces the size of InspectorStack and simplifies the if let Some checks to be simple null pointer checks. The one time memory allocation/deallocation cost is negligible compared to the gains from these small improvements.
~5-10% improvement on forge test.

@DaniPopes DaniPopes force-pushed the dani/inspector-stack-boxes branch from 8dc26ab to 84cfb25 Compare July 25, 2025 13:00
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah

@DaniPopes DaniPopes merged commit 5a552bb into master Jul 25, 2025
22 checks passed
@DaniPopes DaniPopes deleted the dani/inspector-stack-boxes branch July 25, 2025 13:15
@github-project-automation github-project-automation bot moved this to Done in Foundry Jul 25, 2025
grandizzy pushed a commit to grandizzy/foundry that referenced this pull request Jul 29, 2025
grandizzy added a commit that referenced this pull request Jul 29, 2025
* perf: box inspectors in InspectorStack (#11100)

* fix: use existing functions for accountinfo (#11134)

* fix(`anvil`): unwrap panic in `eth/backend/mem/mod.rs` (#11141)

make typed request casting not panic and return useful error to user

---------

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants