feat(cast): add flag to disable HTTPS certificate validation for RPC #10869
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
- Updated `ProviderBuilder` and `RuntimeTransport` to handle the acceptance of invalid certificates. - Modified `Config` to include `eth_rpc_accept_invalid_certs` for managing this setting. - Adjusted related tests to ensure proper functionality of the new feature.
mablr
force-pushed
the
feature/toggle-rpc-cert-validation
branch
from
79f8f2b to
a501dcf
Compare
mattsse
requested changes
Jun 28, 2025
grandizzy
reviewed
Jun 28, 2025
|
@grandizzy it's not a breaking change, sorry for the confusion. I'll fix the test. |
mattsse
approved these changes
Jun 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #10855
Solution
ProviderBuilderandRuntimeTransportto handle the acceptance of invalid certificates.Configto includeeth_rpc_accept_invalid_certsfor managing this setting.PR Checklist