Skip to content

chore(lint): correct some spans #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

chore(lint): correct some spans #10610

merged 2 commits into from
May 23, 2025

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented May 23, 2025

plus touchups

0xrusowsky
0xrusowsky previously approved these changes May 23, 2025
Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yash-atreya
yash-atreya previously approved these changes May 23, 2025
@DaniPopes DaniPopes dismissed stale reviews from yash-atreya and 0xrusowsky via a7601b9 May 23, 2025 15:07
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DaniPopes DaniPopes enabled auto-merge (squash) May 23, 2025 15:10
@DaniPopes DaniPopes merged commit 0cd3a78 into master May 23, 2025
22 checks passed
@DaniPopes DaniPopes deleted the dani/lint-name-spans branch May 23, 2025 15:21
@github-project-automation github-project-automation bot moved this to Done in Foundry May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants