-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(anvil): improve historic state access #10420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anvil): improve historic state access #10420
Conversation
Hi @naijauser, this on the net looks pretty good to me. I know it's been a while since you've opened the PR, but can I ask you to rebase it? |
Done. The code has changed much since, not sure if the issue is still relevant. |
Hi @naijauser, it looks like the rebase resulted in a +0 -0 diff, can you please check that the rebase worked as expected? |
Updated! The diff now shows up. Please take another look, thanks. @onbjerg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks correct to me, would like @DaniPopes to take a look too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @naijauser
Resolved conflicts and made a slight change - removing redundant has_state
lookup
lgtm!
Motivation
Closes 8293.
Hi @mattsse @zerosnacks, pls take a look.
PR Checklist