Skip to content

Conversation

naijauser
Copy link
Contributor

Motivation

Closes 8293.

Hi @mattsse @zerosnacks, pls take a look.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg
Copy link
Contributor

onbjerg commented Aug 25, 2025

Hi @naijauser, this on the net looks pretty good to me. I know it's been a while since you've opened the PR, but can I ask you to rebase it?

@onbjerg onbjerg self-assigned this Aug 25, 2025
@onbjerg onbjerg moved this to In Progress in Foundry Aug 25, 2025
@naijauser
Copy link
Contributor Author

Hi @naijauser, this on the net looks pretty good to me. I know it's been a while since you've opened the PR, but can I ask you to rebase it?

Done. The code has changed much since, not sure if the issue is still relevant.

@onbjerg
Copy link
Contributor

onbjerg commented Aug 26, 2025

Hi @naijauser, it looks like the rebase resulted in a +0 -0 diff, can you please check that the rebase worked as expected?

@naijauser
Copy link
Contributor Author

Hi @naijauser, it looks like the rebase resulted in a +0 -0 diff, can you please check that the rebase worked as expected?

Updated! The diff now shows up. Please take another look, thanks. @onbjerg

onbjerg
onbjerg previously approved these changes Sep 15, 2025
Copy link
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct to me, would like @DaniPopes to take a look too

yash-atreya
yash-atreya previously approved these changes Sep 24, 2025
Copy link
Contributor

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naijauser

Resolved conflicts and made a slight change - removing redundant has_state lookup

lgtm!

@yash-atreya yash-atreya moved this from In Progress to Ready For Review in Foundry Sep 24, 2025
@yash-atreya yash-atreya enabled auto-merge (squash) September 25, 2025 07:50
@grandizzy grandizzy requested a review from onbjerg September 29, 2025 10:08
@yash-atreya yash-atreya merged commit 97241ab into foundry-rs:master Sep 29, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry Sep 29, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

feat(anvil): improve historic state access
4 participants